Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8 #9 #10 - My HA Button category #11

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

mZ738
Copy link

@mZ738 mZ738 commented Jun 5, 2024

Change My Home Assistant Link Repo Type to integration

Change My Home Assistant Link Repo Type to integration
@mZ738 mZ738 requested a review from BJReplay as a code owner June 5, 2024 21:24
@mZ738 mZ738 mentioned this pull request Jun 5, 2024
Copy link

@cromefire cromefire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new link seems to work fine (not that I'm able to give it the go ahead, but still I tested it)

@cromefire
Copy link

cromefire commented Jun 5, 2024

You might wanna give the PR a more meaningful title though, modifying the readme could be basically anything, and you can also link the respective issues with Fixes #<issue number>, so they get automatically closed on merge.

@mZ738
Copy link
Author

mZ738 commented Jun 5, 2024

You might wanna give the PR a more meaningful title though, modifying the readme could be basically anything, and you can also link the respective issues with Fixes #<issue number>, so they get automatically closed on merge.

Yes thanks for the hint. Just created the PR on the Phone :)

@mZ738 mZ738 changed the title Aktualisieren von README.md Fixes #8 #9 #10 - My HA Button category Jun 5, 2024
@BJReplay
Copy link
Owner

BJReplay commented Jun 5, 2024

Thank You!

I will accept this PR, but don't want to break the PR trying to get this into HACS, so will sit on it until HACS process complete, then merge.

@BJReplay BJReplay merged commit 46a4387 into BJReplay:v3 Jun 5, 2024
2 checks passed
@cromefire
Copy link

You might wanna give the PR a more meaningful title though, modifying the readme could be basically anything, and you can also link the respective issues with Fixes #<issue number>, so they get automatically closed on merge.

Yes thanks for the hint. Just created the PR on the Phone :)

It's sufficient btw to write the Fixes # in the issue description. Then when you hover over it in the preview it'll also tell you that it'll close that issue. And you can't chain them I believe and you have to repeat that phrase every time (but there's also github docs explaining it in more detail).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants